Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove snippet config for 'self' #267

Merged
merged 1 commit into from Feb 6, 2019

Conversation

Projects
None yet
3 participants
@AmyShackles
Copy link
Contributor

AmyShackles commented Jul 22, 2018

Fixes #261
Fixes #154

Description of the Change

I removed this snippet:

'.source.python:not(.string)':
  'self':
    'prefix': '.'
    'body': 'self.'

-->

Alternate Designs

I considered retooling the snippet so that there was still a way for 'self' to be auto-populated in some fashion, but ultimately reasoned that the time saved from not having to type four characters is not worth the time lost having it populated accidentally.

Benefits

People will be more likely to use Atom to write their Python scrips. With the current code, 'self' is injected at almost every use of '.' Which, as you can imagine, becomes burdensome, especially since it also applies to text written in comments.

Possible Drawbacks

Some people may be using this feature and they may be annoyed to see it go.

I personally believe that more people would welcome the change than be irritated by the change.

@j2bbayle

This comment has been minimized.

Copy link

j2bbayle commented Jul 23, 2018

Solves #154 as well.

@daviwil

This comment has been minimized.

Copy link
Member

daviwil commented Feb 6, 2019

Thanks @AmyShackles! Agreed, better to remove this for now since it's highly disruptive. If someone can come up with a working alternative for the removed snippet, we'll be happy to accept a PR.

@daviwil daviwil merged commit 6323276 into atom:master Feb 6, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.