Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added async (line 851) #318

Merged
merged 1 commit into from Aug 19, 2020
Merged

Added async (line 851) #318

merged 1 commit into from Aug 19, 2020

Conversation

ThatXliner
Copy link
Contributor

@ThatXliner ThatXliner commented Aug 11, 2020

Added keyword async:

 'illegal_names':
    'match': '\\b(and|as|assert|break|class|continue|def|del|elif|else|except|exec|finally|for|from|global|if|import|in|is|lambda|nonlocal|not|or|pass|print|raise|return|try|while|with|yield|await|async)\\b'
    'name': 'invalid.illegal.name.python'

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions (Does Travis-ci count?)

Description of the Change

Alternate Designs

Benefits

  • People are less likely going to use reserved names for asynchronous stuff

Possible Drawbacks

Code that already uses async as a variable name will be highlighted differently

Applicable Issues

Added keyword async:
```
 'illegal_names':
    'match': '\\b(and|as|assert|break|class|continue|def|del|elif|else|except|exec|finally|for|from|global|if|import|in|is|lambda|nonlocal|not|or|pass|print|raise|return|try|while|with|yield|await|async)\\b'
    'name': 'invalid.illegal.name.python'
```
@sadick254 sadick254 merged commit 2ef1a8a into atom:master Aug 19, 2020
2 checks passed
@ThatXliner ThatXliner deleted the patch-1 branch Aug 19, 2020
@ThatXliner ThatXliner restored the patch-1 branch Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants