Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some kinds of ERB commenting break highlighting #263

Open
csuhta opened this Issue Mar 7, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@csuhta
Copy link

csuhta commented Mar 7, 2019

Prerequisites

Description

Certain kinds of ERB commenting will break the syntax highlighting flow, such as <% # comment %> and <%-# comment %>

Steps to Reproduce

A poorly colorized file shown below:

<%# This is a ERB comment %>
<%= @object.variable %>

<%-# This is also a ERB comment %> <!-- Styles broken past this point --->
<%= @object.variable %>

<%# This is a comment ERB %>
<%= @object.variable %>

<% # This is a comment %> <!-- Styles broken past this point --->
<%= @object.variable %> 

q0rwisizvd

3kcntrvorq

Expected behavior: Syntax highlighting handles the comment

Actual behavior: Syntax highlighting breaks down for future Ruby blocks after the comment

Edit by @rsese to add screenshot

erb-comment-highlighting

Reproduces how often: Always

Versions

Edit by @rsese: also reproduced with 1.37.0-nightly12 on macOS 10.12.

❯❯ apm --version
apm  2.1.2
npm  6.2.0
node 8.9.3 x64
atom 1.33.1
python 2.7.15
git 2.20.1

❯❯ atom --version
Atom    : 1.33.1
Electron: 2.0.16
Chrome  : 61.0.3163.100
Node    : 8.9.3
@rsese

This comment has been minimized.

Copy link
Member

rsese commented Mar 12, 2019

Thanks for the report! Reproduced with 1.37.0-nightly12 on macOS 10.12.6.

erb-comment-highlighting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.