Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tree Sitter syntax highlighting issues for floats and some integer types #259

Merged
merged 2 commits into from Jan 16, 2019

Conversation

Projects
None yet
1 participant
@daviwil
Copy link
Member

daviwil commented Jan 16, 2019

Description of the Change

This change fixes syntax highlighting issues with floats and some integer types when using the Tree Sitter Ruby grammar. The highlighting issues are demonstrated in this screenshot from issue #251:

Here's a screenshot from the fixes to tree-sitter-ruby and language-ruby:

image

Alternate Designs

There is no alternate design, just fixing parsing regexes and scope mappings.

Benefits

Correct highlighting of floats and integers with upcased binary and decimal prefixes.

Possible Drawbacks

None.

Applicable Issues

Fixes #251.
tree-sitter/tree-sitter-ruby#101

@daviwil daviwil merged commit 0292aae into master Jan 16, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@daviwil daviwil deleted the dw-add-float-mapping branch Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.