Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow numerals in all-caps constants #266

Merged
merged 2 commits into from Jul 26, 2019

Conversation

@nathansobo
Copy link
Contributor

commented Jul 26, 2019

Fixes #265

Previously, we only mapped upper-cased constant syntax nodes to the variable.constant scope if they contained upper-case letters or _, and otherwise mapped these constant references to entity.name.type.class. However, upper-case constants can also contain numbers. This PR adds 0-9 to the character class so that upper-case constants containing numbers are mapped to the variable.constant scope as well.

@nathansobo nathansobo force-pushed the ns/digits-in-constants branch from 7a4bd70 to 3991ee8 Jul 26, 2019

@nathansobo nathansobo merged commit ff919d4 into master Jul 26, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nathansobo nathansobo deleted the ns/digits-in-constants branch Jul 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.