Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokenize visibility modifier in Tree-sitter grammar #269

Merged
merged 2 commits into from Aug 5, 2019

Conversation

@jasonrudolph
Copy link
Member

commented Aug 5, 2019

Fixes #268

Before and After

Standalone visibility modifiers

Before

Screen Shot 2019-08-05 at 11 17 50 AM

After

Screen Shot 2019-08-05 at 11 17 11 AM

Per-method visibility modifiers

Before

Screen Shot 2019-08-05 at 11 18 13 AM

After

Screen Shot 2019-08-05 at 11 18 00 AM


馃崘 'd with @as-cii

jasonrudolph and others added some commits Aug 5, 2019

Fix #268
Add syntax highlighting for public, protected, and private "keywords"

Co-Authored-By: Antonio Scandurra <as-cii@github.com>
Add failing test for #268
Co-Authored-By: Antonio Scandurra <as-cii@github.com>

@jasonrudolph jasonrudolph self-assigned this Aug 5, 2019

@jasonrudolph jasonrudolph merged commit 75f1d59 into master Aug 5, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasonrudolph jasonrudolph deleted the fix-268 branch Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.