Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tree-sitter] add variable identifier support in assignments expressions #276

Merged
merged 2 commits into from Oct 31, 2019

Conversation

alxtz
Copy link
Contributor

@alxtz alxtz commented Sep 24, 2019

Description of the Change

image

Originally, variables created from assignments aren't given the .syntax--variable class, which makes the original language-ruby package not able to provide any type of way to style a variable.

Alternate Designs

Some grammar package would also add .syntax--other for this kind of variable, can add if needed.

Applicable Issues

#252 Adding more support for the new used tree-sitter parsing system

@alxtz alxtz changed the title feature: add variable identifier support in assignments [tree-sitter] add variable identifier support in assignments expressions Sep 26, 2019
@rsese
Copy link
Member

@rsese rsese commented Oct 1, 2019

Thanks @alxtz! Since c616809#diff-336e0e422308721e5f4dc0cdc311417f, tests have been added for Tree-sitter grammar changes - are you up for adding tests to help prevent future regressions?

@alxtz
Copy link
Contributor Author

@alxtz alxtz commented Oct 6, 2019

Hi @rsese I've added the corresponding happy path & sad path test for this, can you take a look?

55ab414

@rsese
Copy link
Member

@rsese rsese commented Oct 7, 2019

Awesome, thanks @alxtz I wouldn't be the person reviewing the pull request, just checking for the existence of tests at this point - we can't promise a specific timeframe for review but if there are any followup questions about the tests or anything else, whoever ends up reviewing will comment here in the PR.

@darangi darangi merged commit 3df1958 into atom:master Oct 31, 2019
2 checks passed
@darangi darangi self-assigned this Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants