New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokenize $= selector #232

Merged
merged 1 commit into from Aug 22, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Aug 22, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Not my ideal solution, but it's simple, unlikely to regress, and it works.

Alternate Designs

Non-trivial rewrite of how interpolation is supported in selectors.

Benefits

[...$=...] will work.

Possible Drawbacks

None.

Applicable Issues

Fixes #231

@50Wliu 50Wliu merged commit ac5b564 into master Aug 22, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-ends-with-selector branch Aug 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment