New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix broken highlighting for properties sharing selector names" #238

Merged
merged 1 commit into from Oct 26, 2017

Conversation

Projects
None yet
2 participants
@50Wliu
Member

50Wliu commented Oct 26, 2017

Reverts #234

/cc @dsifford: I'm temporarily reverting this due to #237. Hopefully I can take a look later.

Fixes #237.

@50Wliu 50Wliu merged commit d4e2aaf into master Oct 26, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@50Wliu 50Wliu deleted the revert-234-dsifford-patch-1 branch Oct 26, 2017

@dsifford

This comment has been minimized.

Show comment
Hide comment
@dsifford

dsifford Oct 27, 2017

Contributor

@50Wliu I'll check it out this weekend

Contributor

dsifford commented Oct 27, 2017

@50Wliu I'll check it out this weekend

@dsifford

This comment has been minimized.

Show comment
Hide comment
@dsifford

dsifford Oct 27, 2017

Contributor

@50Wliu I can't replicate this after checking out my PR and merging master into it. Has this been fixed?

Contributor

dsifford commented Oct 27, 2017

@50Wliu I can't replicate this after checking out my PR and merging master into it. Has this been fixed?

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Oct 27, 2017

Member

No, it hasn't. That's strange that you can't repro: I tested on v0.61.2 and then v0.61.1 which didn't contain your PR.

Member

50Wliu commented Oct 27, 2017

No, it hasn't. That's strange that you can't repro: I tested on v0.61.2 and then v0.61.1 which didn't contain your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment