New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly parse prompts led by parentheticals #114

Merged
merged 2 commits into from May 31, 2018

Conversation

Projects
None yet
2 participants
@elyscape
Contributor

elyscape commented May 17, 2018

Description of the Change

As discussed in a comment on #112, parenthetical prefixes as used by virtualenv (and possibly other tools) are not correctly handled. The prefixes added by virtualenv have a space between the closing parentheses, but the regular expression that handles them assumes there to be none. This adds an optional whitespace matcher to deal with this.

Benefits

Improved syntax highlighting on GitHub.

Possible Drawbacks

There shouldn't be any.

@50Wliu

This comment has been minimized.

Member

50Wliu commented May 17, 2018

Looks good! Going to wait a bit to see if these test failures can be fixed before merging.

@50Wliu 50Wliu merged commit 07b1bfe into atom:master May 31, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@elyscape elyscape deleted the elyscape:fix-shell-parens-prefix branch May 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment