New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End herestrings when parentheses are reached #91

merged 1 commit into from Nov 14, 2017


None yet
1 participant

50Wliu commented Nov 14, 2017


  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

) cannot be a part of a word, therefore do not treat it as one in herestrings.

Alternate Designs



Herestrings that are ended by parentheses will be tokenized correctly.

Possible Drawbacks


Applicable Issues

Fixes #90

@50Wliu 50Wliu merged commit 1fd9027 into master Nov 14, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

@50Wliu 50Wliu deleted the wl-herestring-end branch Nov 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment