Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new TSX-aware TreeSitter grammar #37

Merged
merged 2 commits into from May 30, 2019

Conversation

Projects
None yet
2 participants
@nathansobo
Copy link
Contributor

commented May 23, 2019

馃崘'd with @as-cii

This PR updates our TreeSitter grammar dependency to use a separate grammar for TSX that supports type arguments in JSX expressions. See tree-sitter/tree-sitter-typescript#68 for more details on the change. We need to wait for that PR to land so we can publish a new version and update our dependency in this module. These changes were tested by linking locally.

Fixes #34
Closes #33
Fixes atom/ide-typescript#145

Use new TSX-aware TreeSitter grammar
This commit was tested by linking locally and does not yet include the 
dependency upgrade in package.json.

Co-Authored-By: Antonio Scandurra <as-cii@github.com>

@as-cii as-cii merged commit f0df970 into master May 30, 2019

@as-cii as-cii deleted the ns-as/tsx-type-arguments branch May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.