New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete conditionals re: active text editor APIs #50

merged 4 commits into from Aug 10, 2017


None yet
1 participant

jasonrudolph commented Aug 8, 2017

This PR removes the conditional logic (originally introduced in #46) that tested for the existence of atom.workspace.getActiveTextEditor and atom.workspace.observeActiveTextEditor. Now that Atom 1.19 has been released, we can safely expect these methods to to be available:

jasonrudolph added some commits Aug 8, 2017

Remove obsolete conditional re: `atom.workspace.getActiveTextEditor`
Now that 1.19 has shipped, we can expect
atom.workspace.getActiveTextEditor to be available.
Remove obsolete conditional re: `atom.workspace.observeActiveTextEditor`
Now that 1.19 has shipped, we can expect
atom.workspace.observeActiveTextEditor to be available.

@jasonrudolph jasonrudolph merged commit 3fdfa9e into master Aug 10, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@jasonrudolph jasonrudolph deleted the jr-remove-obsolete-conditional branch Aug 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment