This repository has been archived by the owner. It is now read-only.

Improve keybinding documentation #28

Merged
merged 3 commits into from Nov 14, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Nov 14, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Adds a keybinding table to the README that better explains the keybinding situation. Also links to the Flight Manual for customizing keybindings.

A related change moves the command selector to atom-text-editor to better reflect the scenarios in which the command is useful.

Alternate Designs

Add keybindings for Windows and Linux. This package isn't utilized often so I think it's better for people who want keybindings to add them themselves.

Benefits

Less confusion about why ctrl-shift-o opens the "Open Folder" dialog on Windows and Linux.

Possible Drawbacks

None.

Applicable Issues

Closes #9
Supersedes and closes #22

50Wliu added some commits Nov 14, 2017

@50Wliu 50Wliu merged commit 3055df5 into master Nov 14, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-keybindings-docs branch Nov 14, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.