This repository has been archived by the owner. It is now read-only.

Add link command to context menu when appropriate #29

Merged
merged 1 commit into from Nov 14, 2017

Conversation

Projects
None yet
2 participants
@50Wliu
Member

50Wliu commented Nov 14, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Adds an Open link command to the context menu when the cursor is on a link. How convenient!
markdown-link-context-menu

Alternate Designs

None.

Benefits

Easier way to access the link command.

Possible Drawbacks

It appears at the top of the context menu and I'm not too sure why (maybe specificity?). May throw off people who use Undo and Redo regularly.

Applicable Issues

Fixes #16

@50Wliu 50Wliu merged commit 7754426 into master Nov 14, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-add-context-menu branch Nov 14, 2017

@gingerbeardman

This comment has been minimized.

Show comment
Hide comment
@gingerbeardman

gingerbeardman commented Nov 15, 2017

Bravo!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.