Remove atom-space-pen-views #456

merged 3 commits into from Dec 20, 2016


None yet

2 participants

as-cii commented Dec 16, 2016

This pull request contains an architectural change that replaces the usage of atom-space-pen-views with raw DOM APIs. As with other pull requests, there's a risk we might have introduced some regressions. @ungb: can you help me ensure this is not the case? Thanks!

as-cii added some commits Dec 16, 2016
@as-cii as-cii Remove atom-space-pen-views a3ae5d8
@as-cii as-cii Fix tests
@as-cii as-cii referenced this pull request in atom/atom Dec 16, 2016

Remove atom-space-pen-views and custom elements from bundled packages #13254

17 of 27 tasks complete
@ungb ungb fixing package to remove reference to atom-space-pen-views and fixing…
… test failures on window
ungb commented Dec 16, 2016 edited

@as-cii, the package didn't load since there was still require 'atom-space-pen-views'. I removed these reference and saw that the package started working. I'm still testing. I will report back if anything is broken. I'm currently using windows and saw that a few test failed. I worked with @damieng and he helped me fixed these test.

Thanks @damieng.

ungb commented Dec 17, 2016

@as-cii I didn't see any issues using markdown-preview with your changes. I installed and uninstall markdown-preview-plus, looked fine.

@as-cii as-cii merged commit fa741af into master Dec 20, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
@as-cii as-cii deleted the as-remove-space-pen branch Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment