New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disposables #512

Merged
merged 3 commits into from Oct 27, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Oct 27, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Properly clean up after ourselves when disabled.

Alternate Designs

None.

Benefits

Better deactivation process. Previously after disabling markdown-preview the commands would stick around in the command palette.

Possible Drawbacks

None.

Applicable Issues

N/A

50Wliu added some commits Oct 27, 2017

Never mind, it kind of works
Useful for the Markdown Preview option in the context menu

@50Wliu 50Wliu merged commit 441655d into master Oct 27, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@50Wliu 50Wliu deleted the wl-disposables branch Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment