New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict command selector to list of valid Markdown grammars #513

Merged
merged 4 commits into from Oct 28, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Oct 27, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Scenario Before After
Non-Markdown file active commands-not-md-before commands-not-md-after
Markdown file active commands-md-before commands-md-after

Changes:

  • Restrict commands to only appear when a Markdown file is active
  • Fix duplicate keybinding appearing in Command Palette
  • Use the new rich command metadata to prettify HTML in command names

Alternate Designs

None.

Benefits

Less-cluttered and easier-to-parse Command Palette.

Possible Drawbacks

It's slightly harder to test specs.

Applicable Issues

N/A

50Wliu added some commits Oct 27, 2017

@50Wliu 50Wliu merged commit d781c8d into master Oct 28, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-better-commands branch Oct 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment