New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide bullet in task lists #545

Merged
merged 1 commit into from Aug 22, 2018

Conversation

Projects
None yet
1 participant
@simurai
Member

simurai commented Aug 22, 2018

Description of the Change

This change adds a vertical-align style to the label tag.

Alternate Designs

Better would be to add a class (#166), but that is blocked by gjtorikian/task-lists-js#5.

Benefits

When creating checkboxes in markdown, the markdown preview shows the list-style image aligned to the bottom of the list item when it wraps lines.

image

Note the circle displaying next to "element" and "game" in the preview on the right

By adding vertical-align: top to the label, the circle image is covered by the checkbox, as expected.

Possible Drawbacks

Could negatively affect other label stylings in ul elements.

Applicable Issues

Hide bullet in task lists
Co-Authored-By: Amy <amyyf@users.noreply.github.com>

@simurai simurai merged commit 721de24 into master Aug 22, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@simurai simurai deleted the sm-task-list-bullet branch Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment