Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
RIP Google Analytics #100
Description of the Change
Previously, we migrated to send data to GitHub's analytics pipeline. Then we validated the data we are sending to the internal pipeline against Google Analytics to cross check. Everything looks good, so it's time to rip Google Analytics out entirely.
This pull request:
So we have a couple of methods that can send data to the stats store and eventually to GitHub's internal analytics pipeline:
I'd love to rip out
Many of these are dotfiles repos, where users appear to have checked in their .atom file. One of them appears to be a community package: https://github.com/ly1984119/cde-welcome
I chose to err on the more conservative side and avoid the possibility of breaking functionality for our users, even though it leaves this deprecated api cluttering our codebase. If you disagree, let's talk - I'm entirely open to feedback.
I'm also not sure if sending the exceptions to GitHub's analytics pipeline is necessary. Other GitHub apps (such as Desktop) are sending theirs, but Atom already uses BugSnag. Do we really need the exceptions in both places? It could be useful to, for example, compare exception rates of different applications.
The Atom community asked us not to send data to Google Analytics anymore and now we're not. Plus, this cleans up a bunch of redundant code in our unit tests, and rips out a now-unncessary dependency.
I can't think of any but I'm open to feedback, as always.