Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃憰Pin linter to standard v11 #105

Merged
merged 1 commit into from Sep 26, 2018

Conversation

Projects
None yet
1 participant
@jasonrudolph
Copy link
Member

commented Sep 26, 2018

Description of the Change

Prior to this change, this package depended on the latest version of standard. standard 12 was recently released, and it introduced several changes to the linter rules. As a result, the latest commit on master passed CI when it was first pushed to this repository a month ago, but it fails CI now due to the changes in standard 12.

In atom/styleguide#70 (comment), we decided to stick with the linter rules from standard 11 for now. Therefore, this pull request updates this package to depend on standard 11.

Alternate Designs

See atom/styleguide#70 (comment)

Benefits

Fixes CI.

Possible Drawbacks

See atom/styleguide#70 (comment)

@jasonrudolph jasonrudolph merged commit 4f6ff65 into master Sep 26, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasonrudolph jasonrudolph deleted the standard-goes-to-11 branch Sep 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.