Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start logging startup markers #112

Merged
merged 2 commits into from May 10, 2019

Conversation

Projects
None yet
1 participant
@rafeca
Copy link
Contributor

commented May 10, 2019

Description of the Change

This PR adds support to start logging startup markers via the Telemetry package by using an Atom API that is being added to Atom at the moment: atom/atom#19297.

Alternate Designs

N/A

Benefits

More granular data to be able to identify bottlenecks in the startup time of Atom.

Possible Drawbacks

We're logging much more measures which increases the payload sent via the internet connection of the user.

Verification steps

Run Atom and enable the debug mode in the metrics package. Check that new metrics are being sent:

Screenshot 2019-05-10 at 17 32 08

Applicable Issues

atom/atom#13253

rafeca added some commits May 10, 2019

@rafeca rafeca merged commit e65fbc6 into master May 10, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rafeca rafeca deleted the add-startup-timing-data branch May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.