New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send telemetry only with consent #66

Merged
merged 1 commit into from Aug 9, 2016

Conversation

Projects
None yet
3 participants
@damieng
Contributor

damieng commented Aug 2, 2016

All parts are required for this to work correctly;

@damieng damieng merged commit 0985a5f into master Aug 9, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@damieng damieng deleted the telemetry-consent branch Aug 9, 2016

@JonasT

This comment has been minimized.

Show comment
Hide comment
@JonasT

JonasT Jan 2, 2017

Is this setting also used for the crash reporting and only turned on once a user clicks "Ok" in the initial dialog on this? I assume it is due to the comment on the planned relation to exception-reporting in #41 , I just want to be sure this wasn't forgotten.

JonasT commented Jan 2, 2017

Is this setting also used for the crash reporting and only turned on once a user clicks "Ok" in the initial dialog on this? I assume it is due to the comment on the planned relation to exception-reporting in #41 , I just want to be sure this wasn't forgotten.

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu
Member

50Wliu commented Jan 2, 2017

Yes.

@damieng

This comment has been minimized.

Show comment
Hide comment
@damieng

damieng Jan 3, 2017

Contributor

A very limited form of crash reporting for Exceptions uses this flag to control.

Full detailed "dump" crash reporting Chromium/Electron style is currently not enabled in Atom at this time.

Contributor

damieng commented Jan 3, 2017

A very limited form of crash reporting for Exceptions uses this flag to control.

Full detailed "dump" crash reporting Chromium/Electron style is currently not enabled in Atom at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment