Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric to help assess awareness of look-and-feel customizability #96

Merged
merged 3 commits into from Jul 18, 2018

Conversation

Projects
None yet
2 participants
@jasonrudolph
Copy link
Member

jasonrudolph commented Jul 17, 2018

Description of the Change

In much the same way that #95 added a metric to better understand the awareness/approachability of customizing Atom via the user init script, this pull request adds a metric to better understand the awareness/approachability of customizing Atom's look-and-feel via the user stylesheet.

Implementation-wise, this pull request watches for the user's stylesheet to get opened in a TextEditor in Atom. Any time the TextEditor is saved, we record an event indicating that the user has changed their stylesheet.

Alternate Designs

Essentially the same as the alternate designs described in #95, but applied to the user stylesheet instead of the user init script.

Possible Drawbacks

Essentially the same potential drawbacks as those described in #95, but applied to the user stylesheet instead of the user init script.

Verification Process

  • Verify that both styles.less and styles.css are supported
    • Edit and save your styles.less file, and verify that a userStylesheetChanged event is recorded
    • Edit and save your styles.css file, and verify that a userStylesheetChanged event is recorded
  • Verify that Windows paths and macOS/Linux paths are supported
    • Edit and save your user stylesheet on macOS, and verify that a userStylesheetChanged event is recorded
    • Edit and save your user stylesheet on Windows, and verify that a userStylesheetChanged event is recorded
  • Launch Atom with a custom home directory (e.g., ATOM_HOME=/tmp/some-nonstandard-dir), edit and save your user stylesheet, and verify that a userStylesheetChanged event is recorded
@jasonrudolph

This comment has been minimized.

Copy link
Member Author

jasonrudolph commented Jul 17, 2018

@annthurium @maxbrunsfeld @daviwil: 👋 This pull request is super similar to #95. With that in mind, if you'd like to review these changes, I certainly welcome your feedback. But you can also feel free to skip the review if you like. ✌️

@annthurium annthurium assigned annthurium and unassigned annthurium Jul 17, 2018

@annthurium annthurium self-requested a review Jul 17, 2018

@annthurium
Copy link
Contributor

annthurium left a comment

Looks great, @jasonrudolph!

The only thing I can think of to change, is that we have that list of the metrics we're collecting in README.md. Would you mind updating to reflect this new metric?

jasonrudolph added some commits Jul 18, 2018

@jasonrudolph jasonrudolph merged commit cdd5af8 into master Jul 18, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jasonrudolph jasonrudolph deleted the understand-user-stylesheet-awareness branch Jul 18, 2018

@daviwil daviwil referenced this pull request Jul 20, 2018

Closed

Iteration Plan: July 9 - July 20, 2018 #17660

8 of 16 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.