New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebuilt binaries #27

Closed
maxogden opened this Issue Jul 30, 2015 · 16 comments

Comments

Projects
None yet
@maxogden

maxogden commented Jul 30, 2015

Heya, we would love to use this in a CLI module, but don't wanna require users to compile any code to use it.

This week https://github.com/mafintosh/prebuild was written to automate the prebuilt binaries for leveldown, it would be sweet to hook it up to this

@50Wliu 50Wliu added the enhancement label Jul 30, 2015

@pgonzal

This comment has been minimized.

pgonzal commented Nov 24, 2015

+1

The node-keytar package is really useful, and I greatly appreciate everyone's hard work to implement it! However, for our project enlistment instructions, it is pretty cumbersome for us ask every person on the team to install (a specific version of) the entire Python interpreter, and also Visual Studio, just so they can do "npm install" for keytar. It would be really great if keytar included prebuilt binaries like other NPM packages. Thanks!

@amishra0909

This comment has been minimized.

amishra0909 commented Dec 3, 2015

+1
Agreeing with pgonzal. Keytar should be included in set of prebuilt binaries along with other node modules.

@havenchyk

This comment has been minimized.

havenchyk commented Jan 11, 2016

Let's create PR here. @maxogden could you please assist or advice how to do it?

@havenchyk

This comment has been minimized.

havenchyk commented Jan 12, 2016

@zcbenz @kevinsawicki maybe you guys can assist here?

@havenchyk

This comment has been minimized.

havenchyk commented Jan 22, 2016

@egoroof please, stop comments like this, they doesn't make any sense. Read this letter https://github.com/dear-github/dear-github

Issues often accumulate content-less “+1” comments which serve only to spam the maintainers and any others subscribed to the issue. These +1s serve a valuable function in letting maintainers know how widespread an issue is, but their drawbacks are too great. We’d like issues to gain a first-class voting system, and for content-less comments like “+1” or “👍” or “me too” to trigger a warning and instructions on how to use the voting mechanism.

@imlucas

This comment has been minimized.

imlucas commented Mar 16, 2016

Got this working for windows and osx: https://github.com/mongodb-js/node-keytar

Trying to figure out why tests are failing on travis and then will publish up for linux as well. Help more than welcome.

@craxal

This comment has been minimized.

craxal commented Jul 19, 2016

What's the status on this issue? Any prebuilt binaries for Windows, Mac, or Linux?

@alexcroox

This comment has been minimized.

alexcroox commented May 30, 2017

I wonder if the new to node v8 N-API will be of any use here? https://nodejs.org/en/blog/release/v8.0.0/

@alexcroox

This comment has been minimized.

alexcroox commented Jun 26, 2017

@imlucas looks like you managed to fix travis test errors?

@develar

This comment has been minimized.

Contributor

develar commented Jul 3, 2017

PR: #67

Until PR is not merged, you can use keytar-prebuild module instead of this. Binaries published to https://github.com/electron-userland/electron-builder-binaries/releases/tag/v4.0.3 (there are a lot of files because I have published for both keytar and keytar-prebuild module names during testing).

If you use electron-builder — please use electron-builder 19.12.0 — 19.x version doesn't build deps from sources by default and force users to use prebuild binaries to be able to build Electron apps on any platform for any platform.

Prebuilds published for node 6.11.0 / 8.1.3 and for Electron 1.6.11 / 1.7.4.

@popod

This comment has been minimized.

popod commented Jul 20, 2017

Any news for this issus ? Why not merging this PR to allow us to use prebuilt binaries ?

@EugeneBakin

This comment has been minimized.

EugeneBakin commented Nov 30, 2017

@develar Hi, is there a chance that you can publish binaries for node 7.X.0 (abi 51) ?

@develar

This comment has been minimized.

Contributor

develar commented Nov 30, 2017

@EugeneBakin I didn't it by intention — this version is not maintained anymore and you should use latest LTS. Well... if it is really required, I can publish, but are you sure?

@EugeneBakin

This comment has been minimized.

EugeneBakin commented Nov 30, 2017

@develar Since node 7.9.0 is bundled with latest stable electron - we are using it also in development and testing environments. If you can do it - it would be helpful.

Thank you for keytar-prebuild, by the way.

@develar

This comment has been minimized.

Contributor

develar commented Nov 30, 2017

@EugeneBakin As far I see my commit was successful and https://github.com/electron-userland/electron-builder-binaries/releases/tag/v4.0.4 now has node-v51 for all platforms. Nothing to do on your side, just ensure that you use keytar-prebuild 4.0.4 (it is not a new version).

@EugeneBakin

This comment has been minimized.

EugeneBakin commented Nov 30, 2017

@develar Thanks a lot!

@daviwil daviwil closed this in #67 Feb 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment