Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up outstanding V8 warnings about deprecated APIs #186

Merged
merged 1 commit into from May 27, 2019

Conversation

@shiftkey
Copy link
Contributor

commented May 24, 2019

  • no V8 build warnings on Windows
  • no V8 build warnings on macOS
  • no V8 build warnings on Linux

@shiftkey shiftkey force-pushed the no-more-deprecated-apis branch from 5122067 to e18f827 May 24, 2019

@shiftkey shiftkey force-pushed the no-more-deprecated-apis branch from fb722d0 to f7a9f9f May 24, 2019

@shiftkey

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

The last remaining V8 warning on Windows is not relevant to keytar's usage, and will hopefully go away with a future tooling update:

c:\users\appveyor\.node-gyp\5.0.0\include\node\v8.h(4458): warning C4996: 'v8::WasmModuleObject::SerializedModule': was declared deprecated (compiling source file ..\src\async.cc) [C:\projects\node-keytar\build\keytar.vcxproj]
  c:\users\appveyor\.node-gyp\5.0.0\include\node\v8.h(4380): note: see declaration of 'v8::WasmModuleObject::SerializedModule' (compiling source file ..\src\async.cc)
c:\users\appveyor\.node-gyp\5.0.0\include\node\v8.h(10172): warning C4996: 'v8::Value::ToBoolean': was declared deprecated (compiling source file ..\src\async.cc) [C:\projects\node-keytar\build\keytar.vcxproj]
  c:\users\appveyor\.node-gyp\5.0.0\include\node\v8.h(2387): note: see declaration of 'v8::Value::ToBoolean' (compiling source file ..\src\async.cc)

@shiftkey shiftkey merged commit 35b90d1 into master May 27, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@shiftkey shiftkey referenced this pull request Jun 16, 2019
1 of 1 task complete

@shiftkey shiftkey deleted the no-more-deprecated-apis branch Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.