Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrupts (Most) Binary Files #62

Open
kans opened this issue Feb 25, 2015 · 0 comments

Comments

@kans
Copy link

commented Feb 25, 2015

Atom corrupts binary files in many (most?) cases. To test:

  1. make a binary file (eg a tarball)
  2. md5 tarball
  3. open file in atom
  4. save file (you can make a change and undo if you want)
  5. md5 tarball

Pathwatcher just assumes everything is utf8 (before reading the files).
example: https://github.com/atom/node-pathwatcher/blob/master/src/file.coffee#L215

I don't really want to edit binary files in atom (its too damn slow for one thing), but accidentally opening a binary file and saving it is a thing that happens.

@kans kans changed the title Destroys (Most) Binary Files Corrupts (Most) Binary Files Feb 25, 2015

@thedaniel thedaniel added the bug label Feb 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.