Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all compilation errors and warnings for Node.js 12 (V8 7.4). #128

Merged
merged 4 commits into from Jun 12, 2019

Conversation

@benjamn
Copy link
Contributor

benjamn commented May 6, 2019

Depends on the work @abnerlee started in #127.

Meteor can use a fork of the pathwatcher package for now, but it would be great to see these changes released officially sometime soon!

Related: atom/watcher#224 (comment)

abnerlee and others added 2 commits Apr 25, 2019
Depends on s/Handle/Local/ work started by @abnerlee in
#127.
benjamn added a commit to meteor/meteor that referenced this pull request May 6, 2019
benjamn added 2 commits May 8, 2019
I'm sure this isn't the best way to fix this problem, but without it the
pathwatcher package gets installed without a build/Release directory,
which makes the package totally unusable. The unnecessary cleaning happens
because the prepublish script always runs after npm install.

Very open to any other ways of preserving the build/ directory!
@benjamn benjamn force-pushed the meteor:update-for-node-12 branch 2 times, most recently from 60d912b to b83a343 May 8, 2019
@rafeca rafeca self-assigned this Jun 12, 2019
@rafeca
rafeca approved these changes Jun 12, 2019
Copy link
Contributor

rafeca left a comment

Thank you ❤️

@rafeca rafeca merged commit a53cf69 into atom:master Jun 12, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.