Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix all compilation errors and warnings for Node.js 12 (V8 7.4). #128
benjamn added a commit to meteor/meteor that referenced this pull request
May 6, 2019
I'm sure this isn't the best way to fix this problem, but without it the pathwatcher package gets installed without a build/Release directory, which makes the package totally unusable. The unnecessary cleaning happens because the prepublish script always runs after npm install. Very open to any other ways of preserving the build/ directory!
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.