Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Description of the Change
Add a notification log.
I added a working version of the
The way notifications are re-shown would require this to be integrated.
I tried initially just expanding the notification in the log instead of showing it as a pop up but the logic to render fatal errors would need to be reused. It was easier to re-open the pop up notification.
See past notifications.
This was referenced
Jul 25, 2017
I would like some feedback on a few design decisions:
I'm also leaning towards the top.
Summary sounds reasonable.
This would be
Also cool. If there's enough space maybe it can go on the far right.
Another vote for top.
Yeah, one line should be fine and make it easier to scan. Maybe, it could be expanded as an alternative to open a "popup" notification, but out of scope for this PR.
Should the buttons be left aligned, meaning they would show up right after the text:
They won't align, since everything has a dynamic width, but clashes less with the "time ago". Or table columns?
I have quite a few updates to this package (status bar notification count, timeout settings, etc.) that require this pull request to be merged in order to work.
I created a new package with the latest updates since I know it can take a while for a core package to be updated.
referenced this pull request
Nov 2, 2017
@leroix thank you for taking this on.
This pull request helps a few things: