New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default timeout setting #182

Merged
merged 1 commit into from Mar 22, 2018

Conversation

Projects
None yet
2 participants
@UziTech
Contributor

UziTech commented Dec 14, 2017

Description of the Change

Adds a setting so the user can change the default timeout of non-dismissable notifications.

The setting is an integer value in milliseconds.

It defaults to 5 seconds (5000ms) and can be set as low as 1 second (1000ms).

Alternate Designs

We could change it to seconds instead of milliseconds

Benefits

Some people might want the notification to go away quick since they can always open it back up from the notifications log, and some people might want to have more time to read the notifications.

Possible Drawbacks

none

Applicable Issues

none

@UziTech

This comment has been minimized.

Contributor

UziTech commented Feb 19, 2018

@50Wliu can I get this reviewed?

@smashwilson

This comment has been minimized.

Member

smashwilson commented Mar 22, 2018

👍 Sure.

@smashwilson smashwilson merged commit 08340a8 into atom:master Mar 22, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment