This repository has been archived by the owner. It is now read-only.

Add language-html-angular support #109

Merged
merged 3 commits into from May 28, 2018

Conversation

Projects
None yet
2 participants
@jakewtaylor
Contributor

jakewtaylor commented May 23, 2018

Adds in syntax highlighting for the language-html-angular package.

@simurai

The styles/syntax/ng.less file would also need to be imported in https://github.com/atom/one-dark-syntax/blob/master/index.less to take effect: @import "styles/syntax/ng.less";

&.syntax--attribute-with-value {
.syntax--attribute-name {
color: @hue-6-2 !important;

This comment has been minimized.

@simurai

simurai May 25, 2018

Member

Is !important needed here? I tested it with this example and haven't seen a difference.

To increase specificity, .syntax--attribute-name could also be repeated, like

.syntax--attribute-name.syntax--attribute-name {

Then it's still possible to use !important in user's styles.less file to override it.

This comment has been minimized.

@jakewtaylor

jakewtaylor May 25, 2018

Contributor

Yep, not sure why I had that there, works fine without.

@simurai

This comment has been minimized.

Member

simurai commented May 25, 2018

Here a before/after gif with this example:

ng

@jakewtaylor

This comment has been minimized.

Contributor

jakewtaylor commented May 25, 2018

@simurai, I've made the changes - waiting for review 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.