This repository has been archived by the owner. It is now read-only.

Use dropdown as font size picker #245

Merged
merged 2 commits into from Mar 8, 2018

Conversation

Projects
None yet
1 participant
@simurai
Member

simurai commented Mar 8, 2018

Description of the Change

This changes the font size picker to a dropdown instead of a text input.

one

Alternate Designs

Add a longer delay when typing a number.

Benefits

Fixes the following problem with a text input:

  1. if you are at 11 and want to go to 12, you hit delete and it goes to 1.
  2. Because 1 is too small, it automatically changes to 8 (the minimum font size).
  3. Then you type 2. Which is now 82. But since that is over the maximum, it changes to 20.

Possible Drawbacks

Not as quick as a text input to change to a different number.

Applicable Issues

Ref atom/one-light-ui#47

@simurai simurai added this to the 1.26 milestone Mar 8, 2018

@simurai simurai merged commit baa4d56 into master Mar 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@simurai simurai deleted the sm-font-size branch Mar 8, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.