This repository has been archived by the owner. It is now read-only.

Fix tabs.less #248

Merged
merged 1 commit into from Mar 27, 2018

Conversation

Projects
None yet
2 participants
@9585999
Contributor

9585999 commented Mar 17, 2018

After you install and disable the welcome plug and enable one-dark-ui > hide dock toggle button, the activity indicator of the tab disappears.

img_2018-03-17_ _11_23_51

Update tabs.less
After you install and disable the welcome plug, the activity indicator of the tab disappears.

@9585999 9585999 changed the title from Update tabs.less to Fix tabs.less Mar 17, 2018

width: 2px;
background: @accent-color;
atom-pane-axis > atom-pane.active,
atom-pane-container > atom-pane.pane {

This comment has been minimized.

@simurai

simurai Mar 26, 2018

Member

Nice! This would fix #204. 🎉

Although, would it make more sense that the marker only shows with split panes? When there is just one pane, the marker wouldn't be needed.

tabs

In that case the ☝️ above selector atom-pane-container > atom-pane.pane could be removed.

This comment has been minimized.

@9585999

9585999 Mar 26, 2018

Contributor

Personally, my opinion is that the active tab looks better with a marker anyway ...

The interface is much more alive ...

Especially when broken panels the marker is expected to be only in the active tab, the active panel.

kapture 2018-03-26 at 16 17 52

But then again, this is just my opinion.

In any case, the decision to take you :)

This comment has been minimized.

@simurai

simurai Mar 27, 2018

Member

ok, let's merge this. We can still change it later if needed. Always seeing the marker might be good too, so you don't try to find it.

@9585999 Thanks for this PR. 🙇

This comment has been minimized.

@9585999

9585999 Mar 27, 2018

Contributor

@simurai
No problem. Thank you for this UI, as for me this is the best UI at the moment.

@simurai simurai merged commit 2cbe2fb into atom:master Mar 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@simurai simurai added this to the 1.27 milestone Mar 27, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.