This repository has been archived by the owner. It is now read-only.

Replace tree-view focus indicator #114

Merged
merged 1 commit into from Dec 5, 2017

Conversation

Projects
None yet
2 participants
@simurai
Member

simurai commented Dec 5, 2017

@simurai simurai merged commit 6505ccb into master Dec 5, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@simurai simurai deleted the sm-focused-tree-view branch Dec 5, 2017

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Dec 7, 2017

Member

@simurai this is causing low contrast issues for me.
tree-view-low-contrast-unmodified
tree-view-low-contrast-modified
tree-view-low-contrast-new

All three combinations fail WCAG AA, with contrast ratios of 4.33:1, 1.18:1, and 1.24:1 respectively. The github package solved this by switching to white text when focused. But this will be trickier given the different VCS coloring.

Member

50Wliu commented Dec 7, 2017

@simurai this is causing low contrast issues for me.
tree-view-low-contrast-unmodified
tree-view-low-contrast-modified
tree-view-low-contrast-new

All three combinations fail WCAG AA, with contrast ratios of 4.33:1, 1.18:1, and 1.24:1 respectively. The github package solved this by switching to white text when focused. But this will be trickier given the different VCS coloring.

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Dec 7, 2017

Member

Oh also, it makes some icons basically invisible.
tree-view-low-contrast-file-icon

Member

50Wliu commented Dec 7, 2017

Oh also, it makes some icons basically invisible.
tree-view-low-contrast-file-icon

@simurai

This comment has been minimized.

Show comment
Hide comment
@simurai

simurai Dec 7, 2017

Member

Ouch.. sorry. I didn't test this enough.

But this will be trickier given the different VCS coloring.

Right, we could make it white like the GitHub package:

tree-view

but VCS coloring would be lost.

Find another way to show VCS status? Like https://atom.io/themes/city-lights-ui has these circles on the right.

image

Member

simurai commented Dec 7, 2017

Ouch.. sorry. I didn't test this enough.

But this will be trickier given the different VCS coloring.

Right, we could make it white like the GitHub package:

tree-view

but VCS coloring would be lost.

Find another way to show VCS status? Like https://atom.io/themes/city-lights-ui has these circles on the right.

image

@simurai

This comment has been minimized.

Show comment
Hide comment
@simurai

simurai Dec 9, 2017

Member

Tried out a "dot version":

image

But it also makes the tree-view more busy and you can't see the dot when a folder is collapsed. For now I went with the first version ☝️ #117

Member

simurai commented Dec 9, 2017

Tried out a "dot version":

image

But it also makes the tree-view more busy and you can't see the dot when a folder is collapsed. For now I went with the first version ☝️ #117

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.