This repository has been archived by the owner. It is now read-only.

Custom GitHub package inputs #131

Merged
merged 4 commits into from Apr 11, 2018

Conversation

Projects
None yet
1 participant
@simurai
Member

simurai commented Apr 10, 2018

Description of the Change

This PR changes the overlay background color to a mix between the editor and dock background.

Alternate Designs

We could make it darker or even inverted, but since there is no variable for text colors in overlays, text contrast would suffer.

Benefits

Overlays can be differentiated from inputs.

Before After
image image

Possible Drawbacks

Yet another shade of grey.

Applicable Issues

No issue, but reported by @kuychaco

@simurai

This comment has been minimized.

Member

simurai commented Apr 10, 2018

Also added a focus border:

co-author

Should make it look more like they belong together.

@simurai simurai merged commit 37d3a91 into master Apr 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@simurai simurai deleted the sm-overlay branch Apr 11, 2018

@simurai simurai changed the title from Change overlay background color to Custom GitHub package inputs Apr 11, 2018

@simurai simurai referenced this pull request Apr 11, 2018

Merged

Remove One theme hacks #1383

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.