New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Gists #100

Merged
merged 7 commits into from Nov 2, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Nov 2, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Adds support for Gist repositories, which are formatted https://gist.github.com/<hash>#file-<name-with-periods-replaced-by-hyphens>. Note that only the following operations are supported:

  • open-on-github:copy-url
  • open-on-github:file
  • open-on-github:file-on-master (alias to open-on-github:file)
  • open-on-github:history
  • open-on-github:repository

All other commands will open a 404 page.

Alternate Designs

Showing warnings for unsupported operations. I will do this in a follow-up PR that will take care of wikis as well.

Benefits

Gists can be opened by this package.

Possible Drawbacks

None.

Applicable Issues

Fixes #39

50Wliu added some commits Nov 2, 2017

@50Wliu 50Wliu merged commit 392c355 into master Nov 2, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@50Wliu 50Wliu deleted the wl-gist branch Nov 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment