Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get target from command target #111

Merged
merged 5 commits into from Oct 25, 2019
Merged

Get target from command target #111

merged 5 commits into from Oct 25, 2019

Conversation

@UziTech
Copy link
Contributor

UziTech commented Aug 14, 2019

Description of the Change

Get the itemPath from the command target.

Benefits

An editor won't need to be active to open the repo.

Possible Drawbacks

none

Applicable Issues

fixes #91

UziTech added 2 commits Aug 14, 2019
@rsese

This comment has been minimized.

Copy link
Member

rsese commented Aug 20, 2019

Thanks again @UziTech! If you can add tests for your changes, we can add this to the list of items for review.

@rsese rsese added the needs-testing label Aug 20, 2019
@UziTech UziTech force-pushed the UziTech:project-path branch from c15d079 to b5aab0e Aug 20, 2019
@UziTech

This comment has been minimized.

Copy link
Contributor Author

UziTech commented Aug 20, 2019

I moved the getActivePath function to a new file and added tests. It should be good to review.

@rsese

This comment has been minimized.

Copy link
Member

rsese commented Aug 21, 2019

Thank you! 🙇

@rsese rsese added triaged and removed needs-testing labels Aug 21, 2019
@darangi darangi merged commit b0bb91f into atom:master Oct 25, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@darangi darangi self-assigned this Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.