New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup main.js #97

Merged
merged 3 commits into from Nov 2, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Nov 2, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Changes include:

  • Disposing of command subscriptions on package deactivation
  • Removing Babel
  • Changing all lets to const because we don't assign anything
  • Removing useless returns

Alternate Designs

None.

Benefits

The functional change is that commands will no longer work (and no longer appear in the Command Palette) when the package is deactivated, which I think is the expected behavior 馃槈. Also prevents duplicate command subscription if the package is reactivated.

Otherwise, it's just code maintenance.

Possible Drawbacks

None.

Applicable Issues

None.

50Wliu added some commits Nov 2, 2017

@50Wliu 50Wliu merged commit 846e2df into master Nov 2, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@50Wliu 50Wliu deleted the wl-main-cleanup branch Nov 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment