New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor specs #54

Merged
merged 3 commits into from Nov 16, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Nov 16, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Specs no longer require the actual package to be activated and instead just use the PackageGeneratorView class. A considerable amount of duplication between testing for packages, languages, and themes has been 馃敟d and replaced with for loops.

Alternate Designs

None.

Benefits

Better testing.

Possible Drawbacks

None.

Applicable Issues

None.

50Wliu added some commits Nov 16, 2017

@50Wliu 50Wliu merged commit ccbd562 into master Nov 16, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@50Wliu 50Wliu deleted the wl-refactor-specs branch Nov 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment