New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URI handler to show package pane #1011

Merged
merged 2 commits into from Oct 18, 2017

Conversation

Projects
None yet
3 participants
@BinaryMuse
Member

BinaryMuse commented Oct 17, 2017

Adds a URI handler for atom://settings-view/show-package?package=package_name that will open the package's page in Atom.

Depends on atom/atom#11399

BinaryMuse added some commits Oct 17, 2017

@BinaryMuse BinaryMuse merged commit 7716570 into master Oct 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@BinaryMuse BinaryMuse deleted the mkt-add-url-handler-to-show-packages branch Oct 18, 2017

@@ -26,6 +26,13 @@ openPanel = (settingsView, panelName, uri) ->
settingsView.showPanel(panelName, options)
module.exports =
handleUri: (parsed) ->

This comment has been minimized.

@50Wliu

50Wliu Oct 18, 2017

Member

This should be handleURI right?

@50Wliu

50Wliu Oct 18, 2017

Member

This should be handleURI right?

This comment has been minimized.

@BinaryMuse

BinaryMuse Oct 18, 2017

Member

Ah, if we want to match conventions with Atom core, yeah (I'll make that change directly on master), but this case matches what's in package.json.

@BinaryMuse

BinaryMuse Oct 18, 2017

Member

Ah, if we want to match conventions with Atom core, yeah (I'll make that change directly on master), but this case matches what's in package.json.

@akonwi

This comment has been minimized.

Show comment
Hide comment
@akonwi

akonwi Dec 15, 2017

What are your thoughts on extending this so some extra parameters in the URI can be passed to the package if the user decides to install it.

This would allow some interesting experiences. For example, we could potentially pre-configure some package configs before the plugin is installed and immediately after the package is installed, those configs would be applied. It would also be useful for gleaning some info about the pre-atom interactions.

akonwi commented Dec 15, 2017

What are your thoughts on extending this so some extra parameters in the URI can be passed to the package if the user decides to install it.

This would allow some interesting experiences. For example, we could potentially pre-configure some package configs before the plugin is installed and immediately after the package is installed, those configs would be applied. It would also be useful for gleaning some info about the pre-atom interactions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment