Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate cached pkg detail panel on activate/deactivate package #1044

Merged
merged 4 commits into from Jan 14, 2019

Conversation

Projects
None yet
6 participants
@t9md
Copy link
Contributor

t9md commented Jan 28, 2018

Requirements

Description of the Change

Fix #1003

  • Invalidate PackageDetailView panel cache kept in this.panelsByName[pkgName] on activating/deactivating package.
    • Original issue #1003 was happened by returning cached panel.
  • Includes some cleanup
    • Remove unused variables/ library require
    • Quit awkward conditional initialization of instance variable

Alternate Designs

Ideally setting-vew should refresh pkg detail-view on clicking "Enable", "Disable" timing, but that improvement should come as different PR.

Benefits

Enabling/Disabling package from setting-view and accessing setting menu is more intuitive.

Possible Drawbacks

Nothing.

Applicable Issues

#1003

setting-view

@maralv

This comment has been minimized.

Copy link
Contributor

maralv commented Nov 13, 2018

@t9md any work left to be done on this issue or is it simply in need of a review?

@t9md

This comment has been minimized.

Copy link
Contributor Author

t9md commented Nov 13, 2018

No work left, just need a review.

@rsese rsese referenced this pull request Nov 14, 2018

Closed

Disable package doesn't show settings when enabled #1003

1 of 1 task complete

@lee-dohm lee-dohm added the triaged label Nov 19, 2018

@maxbrunsfeld

This comment has been minimized.

Copy link
Contributor

maxbrunsfeld commented Nov 19, 2018

The appveyor failure looks like a flaky test. Rebuilding.

@50Wliu

This comment has been minimized.

Copy link
Member

50Wliu commented Nov 20, 2018

Restarted it a few more times and we're good to go now.

@smashwilson smashwilson merged commit e72b430 into atom:master Jan 14, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@smashwilson

This comment has been minimized.

Copy link
Member

smashwilson commented Jan 14, 2019

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.