Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(restart-notification): undefined latestVersion #1057

Merged
merged 6 commits into from Dec 12, 2018

Conversation

Projects
None yet
3 participants
@FalkF
Copy link
Contributor

FalkF commented Apr 2, 2018

Description of the Change

When installing a package from git url this bug occurs on the first update.
The second update shouldn't be affected because the package gets convertet from git style to normal as part of the update.

This PR makes the code for the detail message more robust and adds sha's for git packages:

git-packages
git-packages2

closes: #1056

To reproduce the bug reset a git package:

  1. apm install thomaslindstrom/color-picker
  2. cd ~/.atom/packages/color-picker
  3. g stash
  4. g reset --hard a296114f3d0deec519a41f4c62e7fc56075b7f01
  5. g stash pop
  6. replace the sha in package.json

Btw. what is the point of having git packages in the first place, when we convert them after the first update?

@lee-dohm

This comment has been minimized.

Copy link
Member

lee-dohm commented Apr 10, 2018

Would it be possible for you to add some tests around this functionality? At least the bits that generate the various strings for display?

FalkF added some commits Apr 12, 2018

@FalkF FalkF force-pushed the FalkF:1056-fix-undefined-latestVersion branch from 8229639 to 343bc36 Apr 12, 2018

50Wliu added some commits Dec 12, 2018

@50Wliu

This comment has been minimized.

Copy link
Member

50Wliu commented Dec 12, 2018

Hmm, Appveyor failure looks real.

@50Wliu 50Wliu merged commit 93622c0 into atom:master Dec 12, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.