New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform search in "Install Panel" automatically after user stops typing #1060

Merged
merged 1 commit into from May 17, 2018

Conversation

Projects
None yet
3 participants
@Tzook

Tzook commented May 4, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

When searching packages in the "Packages" section in settings, it searches automatically upon typing ("onDidStopChanging").
This functionality is missing in the "Install" section. Searching should be consistent and more user friendly. When the user finishes typing, it should just search for him.

Example:
example

Alternate Designs

The previous implementation was search by pressing "enter".

Benefits

A better UX and more consistent experience

Possible Drawbacks

More network requests

Applicable Issues

@lee-dohm

This comment has been minimized.

Member

lee-dohm commented May 15, 2018

Thanks very much for the contribution!

@lee-dohm

This comment has been minimized.

Member

lee-dohm commented May 15, 2018

@daviwil Can you do some quick testing and merge if you don't find any problems?

@daviwil daviwil changed the title from Improve search in "Install Panel" to be performed automatically to Perform search in "Install Panel" automatically after user stops typing May 17, 2018

@daviwil

This comment has been minimized.

Member

daviwil commented May 17, 2018

Just tested this out, works great! Thanks a lot for the contribution @Tzook

@daviwil daviwil merged commit 4b5f8d5 into atom:master May 17, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@daviwil

This comment has been minimized.

Member

daviwil commented May 17, 2018

Just pushed version 0.255.0 of this package and updated Atom on master to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment