Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
:bug: Fix base64 encoded image viewing in package README files. #1087
The sanitize function merges the package path with the image source,
Description of the Change
This PR adds a regex based check for base64 encoded images in package README files, with a similar syntax as surrounding checks.
Prior to this change, all base64 images in README files would break, when viewed from the settings view.
Thanks for your submission!
We require automated tests for all pull requests that include new or changed code. We do this so that we can ensure that we don't accidentally break your shiny new code the next time we or some other contributor submits a change. If you need help writing automated tests for Atom, check out Discuss, the official Atom and Electron message board or join the Atom Slack team. There are a bunch of helpful community members that should be willing to point you in the right direction.