New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix themes dropdown alignment described in issue #995 #1094

merged 1 commit into from Dec 3, 2018


None yet
3 participants
Copy link

ceciliamalmrud commented Nov 27, 2018


  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Fixed misaligned theme dropdown in Themes panel. When changing the size of the window the dropdowns for choosing UI Theme and Syntax Theme was not aligned. Fixed so the Syntax Theme dropdown is at the same height as UI Theme.

Alternate Designs

As this only exists of CSS changes to match the other dropdown's behaviour no other alternatives was considered.


This fixes the bug with misaligned dropdowns and makes it more aesthetically pleasing.

Possible Drawbacks

None that I can see.

Applicable Issues

Misaligned theme dropdowns in Themes panel #995


This comment has been minimized.

Copy link

thomasjo commented Nov 27, 2018

@simurai Mind taking a look at this one?


This comment has been minimized.

Copy link

simurai commented Dec 3, 2018

Works! Thanks @ceciliamalmrud 🙇 ❤️

@simurai simurai merged commit f148277 into atom:master Dec 3, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment