Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing of package versions #1104

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
2 participants
@simurai
Copy link
Member

simurai commented Jan 31, 2019

Description of the Change

This adds some space before the version of packages.

Before:

image

After:

image

Benefits

Easier to read.

Possible Drawbacks

None

Applicable Issues

Fixes #1098

Use margin instead of a <span>
... to add spacing
@Aerijo

This comment has been minimized.

Copy link
Member

Aerijo commented Jan 31, 2019

@simurai Do you happen to know what might have caused it? Or is it just some arcane thing? Fix looks fine in any case.

@simurai

This comment has been minimized.

Copy link
Member Author

simurai commented Jan 31, 2019

Yeah, when converting to Standard, the "space" in the <span> </span> got missing: https://github.com/atom/settings-view/pull/1091/files#diff-249b0f5a1dd5495f0127542df8037f5cL89

Probably better to use CSS instead of markup for spacing.

@simurai simurai merged commit eaa73dd into master Jan 31, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@simurai simurai deleted the sm-fix-package-version branch Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.