Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky breadcrumbs #1105

Merged
merged 1 commit into from Jan 31, 2019

Conversation

Projects
None yet
2 participants
@simurai
Copy link
Member

simurai commented Jan 31, 2019

Description of the Change

This makes the breadcrumbs sticky.

breadcrumbs

Alternate Designs

You can use the navigation on the left to go back, but some users might want to click the breadcrumb navigation instead.

Benefits

When scrolled down a bit, it allows to click the breadcrumbs without having to scroll up again.

Possible Drawbacks

A bit less vertical scrolling space.

Applicable Issues

Resolves #1097

Make the breadcrumbs sticky
So they don't scroll

@simurai simurai merged commit dcfe385 into master Jan 31, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@simurai simurai deleted the sm-fixed-breadcrumbs branch Jan 31, 2019

@Aerijo

This comment has been minimized.

Copy link
Member

Aerijo commented Jan 31, 2019

A bit less vertical scrolling space.

That example appears to have a lot of padding above and below the actual path. Would it be better to reduce this space, especially if it's stickied? Or is that managed by the theme (still relevant though)?

@simurai

This comment has been minimized.

Copy link
Member Author

simurai commented Feb 1, 2019

Would it be better to reduce this space, especially if it's stickied?

Yeah, a bit less height should still be fine.

I'm also playing around with sticky sub sections, but they clash with the breadcrumbs:

breadcrumbs

Might have to refactor whole scrolling area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.