Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky sub-sections #1107

Merged
merged 2 commits into from Feb 4, 2019

Conversation

Projects
None yet
2 participants
@simurai
Copy link
Member

simurai commented Feb 1, 2019

Description of the Change

This PR makes the sub-sections "sticky". Also, the collapsed and uncollapsed icons got replaced with "chevrons" and placed in front.

sticky

Benefits

  • Easier to see what belongs to which subsection.
  • Easier to see if a sub-section is collapsed or not. The fold icons are hard to differentiate.
  • Sub-section can be collapsed after scrolling down.

Possible Drawbacks

None.

Applicable Issues

Inspired by #1105

@simurai

This comment has been minimized.

Copy link
Member Author

simurai commented Feb 1, 2019

Here the packages page:

sticky

@Aerijo

This comment has been minimized.

Copy link
Member

Aerijo commented Feb 1, 2019

Now all it needs to do is remember where it was when you go in and out of a package card / other settings tab.

@simurai

This comment has been minimized.

Copy link
Member Author

simurai commented Feb 1, 2019

Now all it needs to do is remember where it was when you go in and out of a package card / other settings tab.

Unfortunately not.. 😞 but I agree, that would be great.

@simurai simurai merged commit b6d6de2 into master Feb 4, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@simurai simurai deleted the sm-sticky-subsections branch Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.