Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sticky header gap #1112

Merged
merged 1 commit into from Feb 18, 2019

Conversation

Projects
None yet
1 participant
@simurai
Copy link
Member

simurai commented Feb 18, 2019

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

This fixes the 1px gap above sticky headers. Note: It's only reproducible on retina screens. Maybe a rounding error?

Before After
sticky-before sticky-after

Alternate Designs

N/A

Benefits

Less distracting.

Possible Drawbacks

If themes want to add a border or so, it might get cut off.

Applicable Issues

Fixes #1111

@simurai simurai merged commit 3f559df into master Feb 18, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@simurai simurai deleted the sm-sticky-gap branch Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.