Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mock JSON.parse globally in test #1126

Merged
merged 1 commit into from May 2, 2019

Conversation

Projects
None yet
1 participant
@nathansobo
Copy link
Contributor

commented May 2, 2019

We might end up calling it in unrelated code paths, such as @atom/notify, which is why I'm making this change.

Don't mock JSON.parse globally in test
We might end up calling it in unrelated code paths, such as 
@atom/notify, which is why I'm making this change.

@nathansobo nathansobo merged commit 40b1abd into master May 2, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nathansobo nathansobo deleted the ns/no-global-mock branch May 2, 2019

@50Wliu 50Wliu referenced this pull request May 9, 2019

Closed

Searching for packages is throwing a parse error #19293

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.